uranusjr commented on code in PR #59883: URL: https://github.com/apache/airflow/pull/59883#discussion_r2660959708
########## task-sdk/src/airflow/sdk/listeners/__init__.py: ########## @@ -0,0 +1,22 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from airflow.sdk._shared.listeners import hookimpl + +__all__ = ["hookimpl"] Review Comment: Do we need this? You can probably argue Core does for compatibility, but SDK can just import directly from the canonical location, can it not? I also kind of wonder if we should do some additional logic here to avoid having two `hookimpl` objects when both Core and SDK are available. Would it cause issues? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
