amoghrajesh commented on code in PR #59883:
URL: https://github.com/apache/airflow/pull/59883#discussion_r2664088189
##########
shared/listeners/src/airflow_shared/listeners/spec/asset.py:
##########
Review Comment:
We have a type checking block in here:
```python
if TYPE_CHECKING:
from airflow.serialization.definitions.assets import SerializedAsset,
SerializedAssetAlias
```
which is an airflow-core block. There is no runtime impact here, but easing
this with `Any` or removing typing doesn't seem right as providers implementing
this could lose mypy warnings. I could also define a protocol in shared library
but that would be an unwanted maintenance burden to keep this protocol and
actual structure in sync.
cc @potiuk / @uranusjr do you have any thoughts on this? BTW, this is for
all files in spec, I am just pointing assets spec.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
