kaxil commented on code in PR #59883:
URL: https://github.com/apache/airflow/pull/59883#discussion_r2665004311
##########
providers/common/compat/src/airflow/providers/common/compat/sdk.py:
##########
@@ -92,6 +92,8 @@
TaskDeferred as TaskDeferred,
XComNotFound as XComNotFound,
)
+ from airflow.sdk.listeners import hookimpl as hookimpl
+ from airflow.sdk.listeners.listener import get_listener_manager as
get_listener_manager
Review Comment:
```py
from airflow.sdk._shared.listeners import hookimpl as hookimpl
from airflow.sdk.listener import get_listener_manager as get_listener_manager
```
##########
providers/common/compat/src/airflow/providers/common/compat/sdk.py:
##########
@@ -257,6 +259,10 @@
"airflow.utils.log.secrets_masker",
),
#
============================================================================
+ # Listeners
+ #
============================================================================
+ "hookimpl": ("airflow.sdk.listeners", "airflow.listeners"),
+ "get_listener_manager": ("airflow.sdk.listeners.listener",
"airflow.listeners.listener"),
Review Comment:
Should these 2 be?
```py
"hookimpl": ("airflow.sdk._shared.listeners", "airflow.listeners"),
"get_listener_manager": ("airflow.sdk.listener",
"airflow.listeners.listener"),
}
```
##########
providers/common/compat/src/airflow/providers/common/compat/sdk.py:
##########
@@ -92,6 +92,8 @@
TaskDeferred as TaskDeferred,
XComNotFound as XComNotFound,
)
+ from airflow.sdk.listeners import hookimpl as hookimpl
+ from airflow.sdk.listeners.listener import get_listener_manager as
get_listener_manager
Review Comment:
(_I think_)
##########
providers/common/compat/src/airflow/providers/common/compat/sdk.py:
##########
@@ -257,6 +259,10 @@
"airflow.utils.log.secrets_masker",
),
#
============================================================================
+ # Listeners
+ #
============================================================================
+ "hookimpl": ("airflow.sdk.listeners", "airflow.listeners"),
Review Comment:
After @uranusjr's feedback, it looks like this was changed from listeners/
(module) to listener.py (file), but this wasn't updated
##########
shared/listeners/src/airflow_shared/listeners/spec/asset.py:
##########
Review Comment:
This Listener for Asset: where are these called from? and what objects do
they receive?
`SerializedAsset`, `Asset` or both?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
