Ajay9704 commented on code in PR #59999:
URL: https://github.com/apache/airflow/pull/59999#discussion_r2656331480


##########
shared/truncation/src/airflow_shared/truncation/__init__.py:
##########


Review Comment:
   Hi reviewers,
   
   Thank you for pointing out the shared code structure. I've reorganized the 
implementation to follow the proper Airflow shared module pattern that's used 
by other modules like `secrets_masker` ,and also i have gone through   
https://github.com/apache/airflow/blob/main/shared/README.md.
   
   I've now:
   1. Created the implementation in the proper location: 
`shared/truncation/src/airflow_shared/truncation/__init__.py`
   2. Updated both reference files to properly point to the shared 
implementation
   3. Followed the same structural pattern as existing shared modules
   
   This approach aligns with the project's architectural patterns and provides 
better maintainability. I appreciate the guidance on the proper structure.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to