jscheffl commented on code in PR #59999: URL: https://github.com/apache/airflow/pull/59999#discussion_r2656391846
########## shared/truncation/src/airflow_shared/truncation/__init__.py: ########## @@ -0,0 +1,80 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Shared truncation utilities for Airflow.""" + +from __future__ import annotations + +from typing import Any + + +def truncate_rendered_value(rendered: Any, max_length: int) -> str: + """ + Truncate rendered value respecting max_length while accounting for prefix, suffix, and repr() quotes. + + Args: + rendered: The rendered value to truncate (can be any type) + max_length: The maximum allowed length for the output + + Returns: + Truncated string that respects the max_length constraint + """ + if max_length <= 0: + return "" + + prefix = "Truncated. You can change this behaviour in [core]max_templated_field_length. " + suffix = "... " + + if max_length <= len(suffix): + return suffix[:max_length] + + if max_length <= len(prefix) + len(suffix): + # Not enough space for prefix + suffix + content, return truncated prefix + suffix + return (prefix + suffix)[:max_length] + Review Comment: I am not sure if I am happy about this code. It is a bit over-specific. Why if somebody sets less than 79 chars as max make it so complex to cut strings? If somebody configured as such then I would maybe just cut the first 79 chars and leave the hints for length apart. Maybe even if <100 or so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
