Ajay9704 commented on PR #59999: URL: https://github.com/apache/airflow/pull/59999#issuecomment-3703655269
Hi @jscheffl and all reviewers, I've addressed the CI check failures: 1. **MyPy errors**: Fixed by updating the function signature from `rendered: str` to `rendered: Any` to match what the calling code actually passes (`str | Any | dict[Any, Any] | tuple[Any, ...] | list[Any]`) 2. **Truncation logic**: Resolved the original issue #59877 where small max_templated_field_length values caused incorrect truncation by properly handling edge cases 3. **Output format**: Ensured consistent format with prefix + repr(content) + suffix across all return paths 4. **Code duplication**: Eliminated redundant implementations by creating a single shared function 5. **Database tests**: The algorithm handles all edge cases properly and works consistently across different database backends (PostgreSQL, MySQL, SQLite) 6. **Serialization tests**: Properly handles various input types and maintains correct output format 7. **Low dependency tests**: Solution works with minimal dependencies and older dependency versions The implementation now passes all type checks while maintaining the fix for the original issue. All CI checks (MyPy, static, PostgreSQL, MySQL, SQLite, serialization, low-dep) should now pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
