pierrejeambrun commented on code in PR #64644:
URL: https://github.com/apache/airflow/pull/64644#discussion_r3051432724
##########
airflow-core/src/airflow/api_fastapi/core_api/datamodels/dags.py:
##########
@@ -128,6 +128,17 @@ def get_timetable_summary(cls, tts: str | None) -> str |
None:
return None
return str(tts)
+ _NON_BACKFILLABLE_SUMMARIES: frozenset[str | None] = frozenset(
+ {None, "@once", "@continuous", "Asset", "Partitioned Asset"}
+ )
Review Comment:
It's still better than the current null table matching only. But will hold
problems for custom timetables.
##########
uv.lock:
##########
Review Comment:
That seems unrelated to the PR.
##########
airflow-core/src/airflow/ui/src/components/TriggerDag/TriggerDAGModal.tsx:
##########
@@ -72,6 +72,7 @@ const TriggerDAGModal: React.FC<TriggerDAGModalProps> = ({
},
);
+ const isBackfillable = dag?.is_backfillable ?? false;
const hasSchedule = dag?.timetable_summary !== null;
Review Comment:
Is `hasSchedule` still needed? Or should we use `isBackfillable` now?
##########
airflow-core/src/airflow/api_fastapi/core_api/datamodels/dags.py:
##########
@@ -128,6 +128,17 @@ def get_timetable_summary(cls, tts: str | None) -> str |
None:
return None
return str(tts)
+ _NON_BACKFILLABLE_SUMMARIES: frozenset[str | None] = frozenset(
+ {None, "@once", "@continuous", "Asset", "Partitioned Asset"}
+ )
Review Comment:
This will diverge from the `.periodic` attribute (what access here in the
API i.e timetable_summary vs the `timetable.periodic`). Is it possible
similarly to the `timetable_partitioned` to store that in the `DagModel` via a
migration ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
