pierrejeambrun commented on code in PR #64644:
URL: https://github.com/apache/airflow/pull/64644#discussion_r3073396265
##########
airflow-core/src/airflow/cli/commands/dag_command.py:
##########
@@ -275,6 +276,8 @@ def _get_dagbag_dag_details(dag: DAG) -> dict:
"next_dagrun_logical_date": None,
"next_dagrun_run_after": None,
"allowed_run_types": dag.allowed_run_types,
+ "is_backfillable": core_timetable.periodic
+ and (dag.allowed_run_types is None or "backfill" in
dag.allowed_run_types),
Review Comment:
+1 for this, we should use the enum I believe.
##########
airflow-core/src/airflow/ui/public/i18n/locales/ca/components.json:
##########
@@ -13,6 +13,7 @@
"permissionDenied": "Execució de prova fallida: l'usuari no té permís per
crear reompliments.",
"reprocessBehavior": "Comportament de reprocessament",
"run": "Executar reompliment",
+ "scheduleNotBackfillable": "This DAG's schedule does not support
backfills",
Review Comment:
Remove all translation for all languages please. Just keep the one for
`en/components.json` other translation owners will do the extra translation
later, let's not delay this PR over translation.
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/backfills.py:
##########
@@ -262,7 +262,7 @@ def create_backfill(
except (
InvalidReprocessBehavior,
InvalidBackfillDirection,
- DagNoScheduleException,
+ DagNonPeriodicScheduleException,
InvalidBackfillDate,
) as e:
Review Comment:
Irelevant, marking as resolved, catch is done right above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
