Dev-iL commented on code in PR #64644:
URL: https://github.com/apache/airflow/pull/64644#discussion_r3056969897
##########
airflow-core/src/airflow/api_fastapi/core_api/datamodels/dags.py:
##########
@@ -128,6 +128,17 @@ def get_timetable_summary(cls, tts: str | None) -> str |
None:
return None
return str(tts)
+ _NON_BACKFILLABLE_SUMMARIES: frozenset[str | None] = frozenset(
+ {None, "@once", "@continuous", "Asset", "Partitioned Asset"}
+ )
Review Comment:
Done. The string-matching approach (`_NON_BACKFILLABLE_SUMMARIES` frozenset)
has been replaced entirely:
- **Migration 0111** adds a `timetable_periodic` Boolean column to the `dag`
table (same pattern as `timetable_partitioned` — `server_default="0"`,
`nullable=False`).
- **`collection.py`** sets `dm.timetable_periodic = dag.timetable.periodic`
during DAG sync, right next to `timetable_partitioned`.
- **`DAGResponse.is_backfillable`** now reads from `self.timetable_periodic`
(the DB column) instead of string-matching `timetable_summary`. This means
custom timetables that set `periodic = False` are handled correctly.
- The backend checks in `_do_dry_run` and `_create_backfill` continue to use
`dag.timetable.periodic` from the serialized DAG directly — both derive from
the same source.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
