Dev-iL commented on code in PR #64644:
URL: https://github.com/apache/airflow/pull/64644#discussion_r3057036594
##########
airflow-core/src/airflow/ui/src/components/TriggerDag/TriggerDAGModal.tsx:
##########
@@ -72,6 +72,7 @@ const TriggerDAGModal: React.FC<TriggerDAGModalProps> = ({
},
);
+ const isBackfillable = dag?.is_backfillable ?? false;
const hasSchedule = dag?.timetable_summary !== null;
Review Comment:
`hasSchedule` is still needed as it serves a different purpose. It's passed
to `TriggerDAGForm` (line 144) where it controls whether the data interval date
pickers are shown in single-run trigger mode. A Dag with `@once` or
`@continuous` schedule still has a schedule (so `hasSchedule = true`, data
interval pickers shown), but isn't backfillable (`isBackfillable = false`,
backfill radio card disabled).
In short: `hasSchedule` = "does this DAG have any schedule at all?"
(controls data interval UI), `isBackfillable` = "can this DAG be backfilled?"
(controls backfill radio card).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
