Dev-iL opened a new pull request, #64644: URL: https://github.com/apache/airflow/pull/64644
## Context Currently, when attempting to backfill a Dag that has an Asset schedule, after going to the backfill section in the trigger form and choosing dates we get an error saying: "No runs matching selected criteria." (on 2.11 it says "No run dates were found for the given dates and dag interval."). This is confusing UX-wise: instead of being shown right from the start (because it is tied to how the Dag is configured), it appears only after the user selects a date range. This sequence of events implies causality between the user's choice and the error - which is not true. ## Summary - Adds a computed `is_backfillable` boolean field to `DAGResponse`, `DAGDetailsResponse`, and `DAGWithLatestDagRunsResponse` that indicates whether a DAG's schedule supports backfilling. - Replaces the backend's string-based `timetable_summary == "None"` check with a proper `timetable.periodic` check, catching all non-periodic schedules (`@once`, `@continuous`, asset-triggered, partitioned asset) — not just unscheduled DAGs. - Renames `DagNoScheduleException` to `DagNonPeriodicScheduleException` to reflect the broader validation. - Updates the UI to use the new `is_backfillable` field instead of the `hasSchedule` heuristic, so the Backfill option is correctly disabled for all non-periodic DAGs. <img width="911" height="550" alt="image" src="https://github.com/user-attachments/assets/824a4ee9-32c1-4523-9c85-142ae4dbee0b"; /> ## Changes **API / Models:** - `DAGResponse.is_backfillable` — computed field based on `timetable_summary` not being in `{None, @once, @continuous, Asset, Partitioned Asset}`. - `backfill.py` — both `_create_backfill` and `_do_dry_run` now check `dag.timetable.periodic` instead of comparing `timetable_summary` to `"None"`. - Renamed `DagNoScheduleException` → `DagNonPeriodicScheduleException`. **UI:** - `TriggerDAGModal.tsx` uses `is_backfillable` to gate the Backfill radio option. - Updated i18n strings (removed stale `tooltip` key, added `scheduleNotBackfillable`). **Tests:** - New `TestIsBackfillable` parametrized tests for the datamodel computed field. - New `test_create_backfill_non_periodic_schedule_rejected` and `test_do_dry_run_non_periodic_schedule_rejected` tests covering `@once`, `@continuous`, `None`, and asset schedules. - Updated existing `test_no_schedule_dag` to use `schedule=None` instead of `schedule="None"`. <!-- SPDX-License-Identifier: Apache-2.0 https://www.apache.org/licenses/LICENSE-2.0 --> <!-- Thank you for contributing! Please provide above a brief description of the changes made in this pull request. Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/ Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping (in general) for the review if you do not see reaction for a few days (72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications. In case of an existing issue, reference it using one of the following: * closes: #ISSUE * related: #ISSUE --> --- ##### Was generative AI tooling used to co-author this PR? <!-- If generative AI tooling has been used in the process of authoring this PR, please change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by". --> - [ ] Yes (please specify the tool below) <!-- Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) --> --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
