kaxil commented on code in PR #74694:
URL: https://github.com/apache/airflow/pull/74694#discussion_r4289935771
##########
providers/common/ai/docs/changelog.rst:
##########
@@ -39,6 +39,15 @@ Changelog
``capabilities`` or ``spec_file`` move to ``AgentOperator`` or
``@task.agent``. See
:ref:`howto/operator:llm`.
+.. note::
+ ``airflow.providers.common.ai.toolsets.logging.LoggingToolset`` (public
since 0.1.0) is
Review Comment:
The `1.0.0` Features list further down still has "Export
'DataFusionToolset', 'AgentSkillsToolset' and 'LoggingToolset' from 'common.ai'
toolsets (#74449)", and 1.0.0rc1 ships that export, so this section now says
`LoggingToolset` was both exported and removed. If this goes into an rc2, that
line needs `LoggingToolset` dropped. If 1.0.0 goes final from rc1, this note
belongs under the next release instead.
##########
providers/common/ai/docs/frameworks/index.rst:
##########
@@ -136,9 +136,19 @@ Tested versions
- Pins OpenTelemetry at 1.42.1 or lower, below the version in Airflow's
constraints
file. Airflow itself accepts 1.42.1.
-These are the versions the adapter tests have been run against. CI does not
run those
-tests: its environment has ``mcp`` 2.2 and OpenTelemetry 1.44, which Strands
and ADK
-exclude. They run in an environment with the framework installed.
+These are the versions the adapter tests have been run against. The main test
matrix
Review Comment:
This paragraph conflicts with main again: #74768 rewrote it when it added
the OpenAI Agents SDK to the job, and main's version already says pull requests
test against the CI image's versions while scheduled runs use each framework's
own pins. Taking main's paragraph on rebase, and adding back the `amd64` and
selective-checks detail only if you still want it, avoids two descriptions of
the same job. `operators/agent.rst` also conflicts on the `enable_tool_logging`
entry, where main added the tool search sentence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
