o-nikolas commented on code in PR #75998:
URL: https://github.com/apache/airflow/pull/75998#discussion_r4425992261
##########
task-sdk/src/airflow/sdk/execution_time/context.py:
##########
@@ -288,7 +300,9 @@ async def _async_get_connection(conn_id: str) -> Connection:
maybe_awaitable = async_method(conn_id)
Review Comment:
Good catch. Nothing in the repo actually uses this this today, since the
Execution API backend is the only one with async methods and it gets the team
from the task's token. A custom backend would, though, so I'll routed the async
calls through call_secrets_backend_method too and add a test, thought I do
worry about the extra bloat for not much gain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
