o-nikolas commented on code in PR #75998:
URL: https://github.com/apache/airflow/pull/75998#discussion_r4426013781


##########
providers/edge3/src/airflow/providers/edge3/example_dags/integration_test.py:
##########
@@ -128,7 +128,7 @@ def variable():
     def connection():
         try:
             conn = BaseHook.get_connection("integration_test")
-            print(f"Got connection {conn}")
+            print(f"Got connection {conn.conn_id}")

Review Comment:
   CodeQL flagged these two prints once the lookups went through 
call_secrets_backend_method. It treats anything returned from a function with 
"secret" in its name as sensitive, and the Connection repr includes the 
password, so print(conn) counts as clear-text logging. Printing just the 
conn_id clears the alert, and the examples stop printing a password too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to