o-nikolas commented on code in PR #75998:
URL: https://github.com/apache/airflow/pull/75998#discussion_r4429717571
##########
task-sdk/src/airflow/sdk/execution_time/context.py:
##########
@@ -529,7 +554,7 @@ def _set_variable(key: str, value: Any, description: str |
None = None, serializ
SUPERVISOR_COMMS.send(PutVariable(key=key, value=value,
description=description))
# Invalidate cache after setting the variable
- SecretCache.invalidate_variable(key)
+ SecretCache.invalidate_variable(key, team_name=_current_team_name)
Review Comment:
Agreed, I'll route it through `call_secrets_backend_method` like core's
`check_for_write_conflict`. One note on the second example: the env backend
falls back to `AIRFLOW_VAR_MY_VAR` when there's no team var, so a team_a read
still gets the global value and the warning is right there. The missed warning
in the first case is the real gap though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
