o-nikolas commented on code in PR #75998:
URL: https://github.com/apache/airflow/pull/75998#discussion_r4426020807
##########
task-sdk/src/airflow/sdk/execution_time/context.py:
##########
@@ -232,7 +242,9 @@ def _get_connection(conn_id: str) -> Connection:
backends = ensure_secrets_backend_loaded()
for secrets_backend in backends:
try:
- conn = secrets_backend.get_connection(conn_id=conn_id) # type:
ignore[assignment]
+ conn = call_secrets_backend_method(
Review Comment:
Core's Variable.get and Connection.get already go through
call_secrets_backend_method on every lookup, so I kept the SDK the same. The
signature check is small next to the lookup itself. If we want a fast path, I'd
rather add it inside call_secrets_backend_method in a separate PR so core gets
it too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
