potiuk commented on a change in pull request #10708:
URL: https://github.com/apache/airflow/pull/10708#discussion_r482974105



##########
File path: breeze
##########
@@ -651,8 +651,8 @@ function breeze::prepare_command_files() {
 # Prints detailed help for all commands and flags. Used to generate 
documentation added to BREEZE.rst
 # automatically.
 #
-# Used globals:
-#    ALL_BREEZE_COMMANDS
+# Used global variables:
+#    _breeze_all_commands

Review comment:
       All constants should be made 'readonly` according to the guide:
   
   > Some things become constant at their first setting (for example, via 
getopts). Thus, it’s OK to set a constant in getopts or based on a condition, 
but it should be made readonly immediately afterwards.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to