potiuk commented on a change in pull request #10708:
URL: https://github.com/apache/airflow/pull/10708#discussion_r482977729



##########
File path: breeze
##########
@@ -651,8 +651,8 @@ function breeze::prepare_command_files() {
 # Prints detailed help for all commands and flags. Used to generate 
documentation added to BREEZE.rst
 # automatically.
 #
-# Used globals:
-#    ALL_BREEZE_COMMANDS
+# Used global variables:
+#    _breeze_all_commands

Review comment:
       But I am happy to discuss it :). It seems a bit borderline, as they are 
variables, but should not change too much , so using CAPITALISED name might be 
more "natural". However when I change them all to start with _breeze - 
indicated an internal name as well, it seems quite OK to keep those as 
variables. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to