potiuk edited a comment on pull request #10708: URL: https://github.com/apache/airflow/pull/10708#issuecomment-688633019
And yeah. The bats tests work just fine and pre-commit fails when any of the tests fail if that's what you asked for (and with the bats-assert extension it's output is really nice and actionable (just tried to commit a change removing "3.8" pyhon from the expected auto-complete list): ``` Run BATS bash tests for changed bash files........................................................................................Failed - hook id: bats-tests - exit code: 1 1..22 ok 1 Test get_known_values short not ok 2 Test get_known_values long # (from function `breeze_complete::get_known_values_breeze' in file breeze-complete, line 197, # in test file tests/bats/test_breeze_complete.bats, line 36) # `breeze_complete::get_known_values_breeze "--python"' failed # # -- values do not equal -- # expected : 2.7 3.5 3.6 3.7 # actual : 2.7 3.5 3.6 3.7 3.8 # -- # ok 3 Test wrong get_known_values ok 4 Test build options for breeze short ok 5 Test build options for breeze long ok 6 Test listcontains matches ok 7 Test listcontains does not match ok 8 Test convert options short ok 9 Test convert options long ok 10 Test autocomplete --pyt ok 11 Test autocomplete --python ok 12 Test autocomplete --python with prefix ok 13 Test autocomplete --build- ok 14 Test missing value for a parameter ok 15 Test wrong value for a parameter but proper stored in the .build/PARAM ok 16 Test wrong value for a parameter stored in the .build/PARAM ok 17 Test correct value for a parameter ok 18 Test correct value for a parameter from multi-line values ok 19 Test read_parameter from missing file ok 20 Test read_parameter from file ok 21 empty test ok 22 convert volume list to docker params ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
