XBaith commented on code in PR #3273:
URL: https://github.com/apache/amoro/pull/3273#discussion_r1964920695
##########
amoro-ams/src/test/java/org/apache/amoro/server/optimizing/maintainer/TestDataExpire.java:
##########
@@ -591,6 +592,7 @@ protected static Map<String, String> getDefaultProp() {
prop.put(TableProperties.ENABLE_DATA_EXPIRATION, "true");
prop.put(TableProperties.DATA_EXPIRATION_FIELD, "op_time");
prop.put(TableProperties.DATA_EXPIRATION_RETENTION_TIME, "1d");
+ prop.put("write.metadata.metrics.default", "none");
Review Comment:
You are right. It should not be the default property. It's a good idea to
create a new test case to check that `write.metadata.metrics.default` is `none`
to trigger data expiration based on partition informatio
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
