XBaith commented on code in PR #3273:
URL: https://github.com/apache/amoro/pull/3273#discussion_r1970840970
##########
amoro-ams/src/test/java/org/apache/amoro/server/optimizing/maintainer/TestDataExpire.java:
##########
@@ -194,7 +196,8 @@ private void testUnKeyedPartitionLevel() {
List<Record> expected;
if (tableTestHelper().partitionSpec().isPartitioned()) {
- if (expireByStringDate()) {
+ // retention time is 1 day, expire partitions that order than 2022-01-02
+ if (expireByStringDate() && isMetricsNotNone()) {
Review Comment:
We should keep the same result even if metrics mode is `none`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
