lintingbin commented on code in PR #3273:
URL: https://github.com/apache/amoro/pull/3273#discussion_r1964932397
##########
amoro-ams/src/test/java/org/apache/amoro/server/optimizing/maintainer/TestDataExpire.java:
##########
@@ -591,6 +592,7 @@ protected static Map<String, String> getDefaultProp() {
prop.put(TableProperties.ENABLE_DATA_EXPIRATION, "true");
prop.put(TableProperties.DATA_EXPIRATION_FIELD, "op_time");
prop.put(TableProperties.DATA_EXPIRATION_RETENTION_TIME, "1d");
+ prop.put("write.metadata.metrics.default", "none");
Review Comment:
You're right, I should create a set of test cases with
"write.metadata.metrics.default" set to "none." However, I'm currently stuck
with the issue that configuring "write.metadata.metrics.default" as "none" in
the test cases doesn't take effect. Even when I set
"write.metadata.metrics.default" to "none," the upper_bound is still being
recorded in the metrics. Could you help me take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
