XBaith commented on code in PR #3273:
URL: https://github.com/apache/amoro/pull/3273#discussion_r1965034607
##########
amoro-ams/src/test/java/org/apache/amoro/server/optimizing/maintainer/TestDataExpire.java:
##########
@@ -591,6 +592,7 @@ protected static Map<String, String> getDefaultProp() {
prop.put(TableProperties.ENABLE_DATA_EXPIRATION, "true");
prop.put(TableProperties.DATA_EXPIRATION_FIELD, "op_time");
prop.put(TableProperties.DATA_EXPIRATION_RETENTION_TIME, "1d");
+ prop.put("write.metadata.metrics.default", "none");
Review Comment:
Looks like iceberg GenericAppenderFactory do not put the right metric
configs. Currently, I think we can just add a new test for setting metric
property as `none`, then I will report the issue and try to fix it in Iceberg.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
