shuashuai commented on PR #785: URL: https://github.com/apache/incubator-answer/pull/785#issuecomment-1965674439
First of all, I want to talk about how to make a better contribution. From a developer's point of view, each PR should be clear. The current PR solves a specific problem or completes a complete function; if you If there are multiple features or Isuu that need to be contributed, they should be split into multiple PRs to submit, so that there will be no additional burden when others come to Reiview. Secondly, when changing some project configurations or basic environments, a discussion needs to be initiated first, and then community users will decide whether these configurations or environments need to be changed. > Use NodeJS 18 and higher We only need the minimum version to ensure the normal operation of the project > Removed pnpm force We started with pnpm for a few reasons 1. pnpm has better performance and memory management than yarn or npm. 2. our CI also uses pnpm and our team uses pnpm as the front-end package management tool. 3. for developers or contributors, it is up to them to decide which package management tool to use. They just need to make sure not to submit these files when submitting a PR. > updated all NodeJS dependencies for the frontend to latest version whether dependencies need to be upgraded, we will decide based on the security report and whether the existing dependencies meet the functions of the current version. Each dependency upgrade requires a lot of testing, so a certain dependency needs to be upgraded. Please explain the reason for the upgrade, and we will update it. Determine whether to upgrade based on specific circumstances > No link to the GitHub release page of Answer, if version already up to date If need to do this, please go to ISSU to initiate a discussion. We will decide whether adjustments are needed based on user feedback. Finally, thank you very much for your contribution. If you have any questions, you can continue the discussion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
