Justman100 commented on code in PR #785:
URL: https://github.com/apache/incubator-answer/pull/785#discussion_r1504054144
##########
script/build_plugin.sh:
##########
@@ -16,28 +16,29 @@
# specific language governing permissions and limitations
# under the License.
-set -e
-echo "begin build plugin"
-plugin_file=./script/plugin_list
-if [ ! -f "$plugin_file" ]; then
+cmd="./answer build"
+
+echo "Check, if file plugin_list exist"
+sleep 1
Review Comment:
The text, that is output with `echo`, should be more eye-catching before the
script continues
##########
script/build_plugin.sh:
##########
@@ -16,28 +16,29 @@
# specific language governing permissions and limitations
# under the License.
-set -e
-echo "begin build plugin"
-plugin_file=./script/plugin_list
-if [ ! -f "$plugin_file" ]; then
+cmd="./answer build"
+
+echo "Check, if file plugin_list exist"
+sleep 1
+if ! [ -f "plugin_list" ]; then
echo "plugin_list is not exist"
exit 0
fi
-echo "plugin_list exist"
-cmd="./answer build "
-for repo in `cat $plugin_file`
-do
- echo ${repo}
- cmd=$cmd" --with "${repo}
+echo "Begin build plugin..."
+sleep 1
Review Comment:
Like said
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
