Justman100 commented on code in PR #785:
URL: https://github.com/apache/incubator-answer/pull/785#discussion_r1504087004


##########
internal/install/install_req.go:
##########
@@ -96,13 +96,13 @@ type InitEnvironmentResp struct {
 
 // InitBaseInfoReq init base info request
 type InitBaseInfoReq struct {
-       Language      string `validate:"required,gt=0,lte=30" json:"lang"`
-       SiteName      string `validate:"required,sanitizer,gt=0,lte=30" 
json:"site_name"`
+       Language      string `validate:"required,gt=0,lte=32" json:"lang"`
+       SiteName      string `validate:"required,sanitizer,gt=0,lte=32" 
json:"site_name"`
        SiteURL       string `validate:"required,gt=0,lte=512,url" 
json:"site_url"`
-       ContactEmail  string `validate:"required,email,gt=0,lte=500" 
json:"contact_email"`
-       AdminName     string `validate:"required,gt=3,lte=30" json:"name"`
-       AdminPassword string `validate:"required,gte=8,lte=32" json:"password"`
-       AdminEmail    string `validate:"required,email,gt=0,lte=500" 
json:"email"`
+       ContactEmail  string `validate:"required,email,gt=0,lte=512" 
json:"contact_email"`
+       AdminName     string `validate:"required,gt=2,lte=64" json:"name"`
+       AdminPassword string `validate:"required,gte=4,lte=128" json:"password"`
+       AdminEmail    string `validate:"required,email,gt=0,lte=512" 
json:"email"`

Review Comment:
   The users have to decide whether they want to use an insecure password... 
Longer names, passwords and mails are also possible



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to