Justman100 commented on PR #785: URL: https://github.com/apache/incubator-answer/pull/785#issuecomment-1999049987
> First of all, I want to talk about how to make a better contribution. From a developer's point of view, each PR should be clear. The current PR solves a specific problem or completes a complete function; if you If there are multiple features or Isuu that need to be contributed, they should be split into multiple PRs to submit, so that there will be no additional burden when others come to Reiview. > > Secondly, when changing some project configurations or basic environments, a discussion needs to be initiated first, and then community users will decide whether these configurations or environments need to be changed. > > > Use NodeJS 18 and higher > > We only need the minimum version to ensure the normal operation of the project > > > Removed pnpm force > > We started with pnpm for a few reasons > > 1. pnpm has better performance and memory management than yarn or npm. > > 2. our CI also uses pnpm and our team uses pnpm as the front-end package management tool. > > 3. for developers or contributors, it is up to them to decide which package management tool to use. They just need to make sure not to submit these files when submitting a PR. > > > > updated all NodeJS dependencies for the frontend to latest version > > whether dependencies need to be upgraded, we will decide based on the security report and whether the existing dependencies meet the functions of the current version. Each dependency upgrade requires a lot of testing, so a certain dependency needs to be upgraded. Please explain the reason for the upgrade, and we will update it. Determine whether to upgrade based on specific circumstances > > > No link to the GitHub release page of Answer, if version already up to date > > If need to do this, please go to ISSU to initiate a discussion. We will decide whether adjustments are needed based on user feedback. > > > Version check is skipped if Answer was installed directly from GitHub > > Reference here #764 > > Finally, thank you very much for your contribution. If you have any questions, you can continue the discussion. 1. So, one cannot use capital letters during the installation, which is definitely not the way it should be! The database doesn't care if the username is uppercase or lowercase! 2. Updating dependencies only when *it's needed* is the stupidest setting you can have! Nobody updates their dependencies only when *it's needed*! One always does it, even if there are no security risks 3. In the script to build the plugins, the sleep statements are intentional, because one can only read the text that is output by echo before the script bombs the console, and one can no longer read it properly 4. Do I have to initialise the TryToInstallByEnv again so that the variable`installByEnv` gets a value? 5. The tag check when asking questions is superfluous, as one does not need it to be able to ask questions (a tag force is also quite bold) Furthermore, I test all my changes before I push them! So all my commits can be merged without hesitation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
