kevingurney commented on code in PR #326:
URL: https://github.com/apache/arrow-site/pull/326#discussion_r1123109756
##########
.github/workflows/deploy.yml:
##########
@@ -27,17 +27,33 @@ jobs:
deploy:
name: Deploy
runs-on: ubuntu-latest
+ container:
+ image: ubuntu:latest
steps:
- - uses: actions/checkout@v2
- - uses: ruby/setup-ruby@v1
+ - name: Update packages
+ run: |
+ apt-get update -qq
+ - name: Install dependencies
+ run: |
+ apt-get install -qq -y jq rsync git libyaml-0-2 npm
+ - name: Checkout git repository
+ uses: actions/checkout@v2
+ - name: Set GitHub workspace as git safe.directory # Required to work
around: https://github.com/actions/checkout/issues/766
+ run: |
+ git config --global --add safe.directory "$GITHUB_WORKSPACE"
Review Comment:
I think the change you are referring to is actions/checkout#762?
This quote below makes me think that I still need to set `safe.directory`
separately from the checkout since the original setting doesn't persist across
workflow steps:
> This does carry some limitations, it doesn't persist this configuration
for the duration of the job mainly. So if your job pushes to git or something
after checkout, that will continue to fail. We need to figure out how to
address this at an ecosystem level, outside of the checkout action.
Also, this quote from
https://github.com/actions/checkout/issues/766#issue-1204908242 (which is still
an open issue):
> Since we don't persist that configuration, you may still see this error if
your job uses git commands outside of the checkout action. If so, you just need
to set the configuration value yourself.
It's possible I am mistaken, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
