kevingurney commented on code in PR #326:
URL: https://github.com/apache/arrow-site/pull/326#discussion_r1124089002
##########
.github/workflows/deploy.yml:
##########
@@ -27,17 +27,33 @@ jobs:
deploy:
name: Deploy
runs-on: ubuntu-latest
+ container:
+ image: ubuntu:latest
steps:
- - uses: actions/checkout@v2
- - uses: ruby/setup-ruby@v1
+ - name: Update packages
+ run: |
+ apt-get update -qq
+ - name: Install dependencies
+ run: |
+ apt-get install -qq -y jq rsync git libyaml-0-2 npm
+ - name: Checkout git repository
+ uses: actions/checkout@v3
+ - name: Set GitHub workspace as git safe.directory # Required to work
around: https://github.com/actions/checkout/issues/766
+ run: |
+ git config --global --add safe.directory "$GITHUB_WORKSPACE"
+ - name: Install Ruby
+ uses: ruby/setup-ruby@v1
with:
- bundler-cache: true
- - uses: actions/setup-node@v2
+ bundler-cache: true
+ env:
+ ImageOS: ubuntu22
+ - name: Install Node.js
+ uses: actions/setup-node@v2
with:
- cache: "npm"
- - name: Install dependencies
+ cache: "npm"
+ - name: Install Ruby dependencies
run: |
- bundle install
+ bundle install
Review Comment:
Excellent point! I misunderstood how the caching works. Thanks for pointing
this out.
I should have checked the [`ruby/setup-ruby`
documentation](https://github.com/ruby/setup-ruby#caching-bundle-install-automatically)
which clearly states this:
> Note that any step doing bundle install (for the root Gemfile) or gem
install bundler can be removed with bundler-cache: true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
