kou commented on code in PR #326:
URL: https://github.com/apache/arrow-site/pull/326#discussion_r1123686514
##########
.github/workflows/deploy.yml:
##########
@@ -27,17 +27,33 @@ jobs:
deploy:
name: Deploy
runs-on: ubuntu-latest
+ container:
+ image: ubuntu:latest
steps:
- - uses: actions/checkout@v2
- - uses: ruby/setup-ruby@v1
+ - name: Update packages
+ run: |
+ apt-get update -qq
+ - name: Install dependencies
+ run: |
+ apt-get install -qq -y jq rsync git libyaml-0-2 npm
+ - name: Checkout git repository
+ uses: actions/checkout@v3
+ - name: Set GitHub workspace as git safe.directory # Required to work
around: https://github.com/actions/checkout/issues/766
+ run: |
+ git config --global --add safe.directory "$GITHUB_WORKSPACE"
+ - name: Install Ruby
+ uses: ruby/setup-ruby@v1
with:
- bundler-cache: true
- - uses: actions/setup-node@v2
+ bundler-cache: true
+ env:
+ ImageOS: ubuntu22
+ - name: Install Node.js
+ uses: actions/setup-node@v2
with:
- cache: "npm"
- - name: Install dependencies
+ cache: "npm"
Review Comment:
Could you keep 2-spaces indent?
##########
.github/workflows/deploy.yml:
##########
@@ -27,17 +27,33 @@ jobs:
deploy:
name: Deploy
runs-on: ubuntu-latest
+ container:
+ image: ubuntu:latest
steps:
- - uses: actions/checkout@v2
- - uses: ruby/setup-ruby@v1
+ - name: Update packages
+ run: |
+ apt-get update -qq
+ - name: Install dependencies
+ run: |
+ apt-get install -qq -y jq rsync git libyaml-0-2 npm
+ - name: Checkout git repository
+ uses: actions/checkout@v3
+ - name: Set GitHub workspace as git safe.directory # Required to work
around: https://github.com/actions/checkout/issues/766
+ run: |
+ git config --global --add safe.directory "$GITHUB_WORKSPACE"
+ - name: Install Ruby
+ uses: ruby/setup-ruby@v1
with:
- bundler-cache: true
- - uses: actions/setup-node@v2
+ bundler-cache: true
+ env:
+ ImageOS: ubuntu22
+ - name: Install Node.js
+ uses: actions/setup-node@v2
with:
- cache: "npm"
- - name: Install dependencies
+ cache: "npm"
+ - name: Install Ruby dependencies
run: |
- bundle install
+ bundle install
Review Comment:
We can remove this because `bundler-cache: true` for `ruby/setup-ruby` does
this.
##########
.github/workflows/deploy.yml:
##########
@@ -27,17 +27,33 @@ jobs:
deploy:
name: Deploy
runs-on: ubuntu-latest
+ container:
+ image: ubuntu:latest
Review Comment:
How about specifying `22.04` explicitly because we also need to specify
corresponding `ImageOS: ubuntu22` for `ruby/setup-ruby`?
```suggestion
image: ubuntu:22.04
```
##########
.github/workflows/deploy.yml:
##########
@@ -27,17 +27,33 @@ jobs:
deploy:
name: Deploy
runs-on: ubuntu-latest
+ container:
+ image: ubuntu:latest
steps:
- - uses: actions/checkout@v2
- - uses: ruby/setup-ruby@v1
+ - name: Update packages
Review Comment:
```suggestion
- name: Update package list
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
