ASF GitHub Bot logged work on BEAM-4070:

                Author: ASF GitHub Bot
            Created on: 16/Apr/18 19:36
            Start Date: 16/Apr/18 19:36
    Worklog Time Spent: 10m 
      Work Description: robertwb commented on issue #5134: [BEAM-4070]: Make 
cython: profile=False by default
URL: https://github.com/apache/beam/pull/5134#issuecomment-381723162
   The motivation to keep these profiles is so that one can use standard tools
   like cProfile to understand the code. I would disable them only for
   modules/functions where they can be shown to be non-negligable.
   On Mon, Apr 16, 2018 at 12:31 PM Ahmet Altay <notificati...@github.com>
   > Thank you @boyuanzz <https://github.com/boyuanzz>, could you look at the
   > failing tests? Could you also run a simple benchmark, curious if we can get
   > improvements this way?
   > @robertwb <https://github.com/robertwb> is there a reason to keep these
   > profiles in. (Based on
   > http://cython.readthedocs.io/en/latest/src/tutorial/profiling_tutorial.html
   > I do not think so.)
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/beam/pull/5134#issuecomment-381722016>, or mute
   > the thread
   > .

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 91446)
    Time Spent: 0.5h  (was: 20m)

> Disable cython profiling by default
> -----------------------------------
>                 Key: BEAM-4070
>                 URL: https://issues.apache.org/jira/browse/BEAM-4070
>             Project: Beam
>          Issue Type: Task
>          Components: sdk-py-core
>            Reporter: Boyuan Zhang
>            Assignee: Boyuan Zhang
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
> Enabling cython profiling adds some overhead.
> http://cython.readthedocs.io/en/latest/src/tutorial/profiling_tutorial.html

This message was sent by Atlassian JIRA

Reply via email to