ASF GitHub Bot logged work on BEAM-4070:

                Author: ASF GitHub Bot
            Created on: 16/Apr/18 20:23
            Start Date: 16/Apr/18 20:23
    Worklog Time Spent: 10m 
      Work Description: boyuanzz commented on issue #5134: [BEAM-4070]: Make 
cython: profile=False by default
URL: https://github.com/apache/beam/pull/5134#issuecomment-381736955
   Ran distribution_counter_microbenchmark:
   Disable cython profiling:
   Per element update time cost: 1.94871425629e-08
   Enable cython profiling:
   Per element update time cost: 2.2584438324e-08
   Ran map_fn_microbenchmark.py
   Disable cython profiling:
   Fixed cost   0.912458370739
   Per-element  1.03488045028e-06
   R^2          0.950584928612
   Enable cython profiling:
   Fixed cost   0.912591088374
   Per-element  1.08467976252e-06
   R^2          0.924557343352
   It seems, disable profiling does improve performance(ah...maybe a little). 
But I think it's valuable to disable it at least along hot path, eg, 
operations.py, windlow_value.py. How do you feel like? @aaltay  @robertwb 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 91462)
    Time Spent: 1.5h  (was: 1h 20m)

> Disable cython profiling by default
> -----------------------------------
>                 Key: BEAM-4070
>                 URL: https://issues.apache.org/jira/browse/BEAM-4070
>             Project: Beam
>          Issue Type: Task
>          Components: sdk-py-core
>            Reporter: Boyuan Zhang
>            Assignee: Boyuan Zhang
>            Priority: Major
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
> Enabling cython profiling adds some overhead.
> http://cython.readthedocs.io/en/latest/src/tutorial/profiling_tutorial.html

This message was sent by Atlassian JIRA

Reply via email to