ASF GitHub Bot logged work on BEAM-4070:

                Author: ASF GitHub Bot
            Created on: 16/Apr/18 22:22
            Start Date: 16/Apr/18 22:22
    Worklog Time Spent: 10m 
      Work Description: aaltay commented on issue #5134: [BEAM-4070]: Make 
cython: profile=False by default
URL: https://github.com/apache/beam/pull/5134#issuecomment-381768898
   I am a bit conflicted. 
   There is a clear value of being able to profile by default. (Is this 
something we can control by a config file instead of this pragma comments?)
   Micro benchmarks show some gains, although I do not want to base our 
decision purely on micro benchmarks.
   Another thing I learnt by reading 
http://cython.readthedocs.io/en/latest/src/tutorial/profiling_tutorial.html is 
that, cython profilin may effectively disable inlining, and it is possilbe to 
use `@cython.profile(False)` to disable only in those cases. Perhaps we can 
give that I try.
   I think, based on the given information it is premature to make this change.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 91525)
    Time Spent: 1h 40m  (was: 1.5h)

> Disable cython profiling by default
> -----------------------------------
>                 Key: BEAM-4070
>                 URL: https://issues.apache.org/jira/browse/BEAM-4070
>             Project: Beam
>          Issue Type: Task
>          Components: sdk-py-core
>            Reporter: Boyuan Zhang
>            Assignee: Boyuan Zhang
>            Priority: Major
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
> Enabling cython profiling adds some overhead.
> http://cython.readthedocs.io/en/latest/src/tutorial/profiling_tutorial.html

This message was sent by Atlassian JIRA

Reply via email to