[
https://issues.apache.org/jira/browse/BEAM-4048?focusedWorklogId=98131&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-98131
]
ASF GitHub Bot logged work on BEAM-4048:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/May/18 06:29
Start Date: 04/May/18 06:29
Worklog Time Spent: 10m
Work Description: rangadi commented on a change in pull request #5249:
[BEAM-4048] Refactor COMBINE mode for reading/writing from/to Pub/Sub and Kafka
in Nexmark
URL: https://github.com/apache/beam/pull/5249#discussion_r185998428
##########
File path:
sdks/java/nexmark/src/main/java/org/apache/beam/sdk/nexmark/NexmarkLauncher.java
##########
@@ -1023,8 +1037,15 @@ private void sinkResultsToBigQuery(
break;
case SUBSCRIBE_ONLY:
case COMBINED:
- // Read events from pubsub.
- source = sourceEventsFromPubsub(p, now);
+ {
+ // Read events from Kafka or Pubsub.
+ if (configuration.sourceType == NexmarkUtils.SourceType.KAFKA) {
+ source =
+ sourceEventsFromKafka(p, configuration.pubSubMode ==
COMBINED ? now : null);
Review comment:
Please add a comment about why we pass now based on `pubsubMode`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 98131)
> Refactor COMBINE mode for reading and writing from/to Pub/Sub and Kafka in
> Nexmark
> ----------------------------------------------------------------------------------
>
> Key: BEAM-4048
> URL: https://issues.apache.org/jira/browse/BEAM-4048
> Project: Beam
> Issue Type: Improvement
> Components: examples-nexmark
> Reporter: Etienne Chauchot
> Assignee: Alexey Romanenko
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
