[
https://issues.apache.org/jira/browse/BEAM-4048?focusedWorklogId=98334&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-98334
]
ASF GitHub Bot logged work on BEAM-4048:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/May/18 14:59
Start Date: 04/May/18 14:59
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on a change in pull request
#5249: [BEAM-4048] Refactor COMBINE mode for reading/writing from/to Pub/Sub
and Kafka in Nexmark
URL: https://github.com/apache/beam/pull/5249#discussion_r186109724
##########
File path:
sdks/java/nexmark/src/main/java/org/apache/beam/sdk/nexmark/NexmarkOptions.java
##########
@@ -407,19 +407,19 @@
void setQueryLanguage(String value);
- @Description("Base name of Kafka source topic in streaming mode.")
+ @Description("Base name of Kafka events topic in streaming mode.")
@Nullable
- @Default.String("nexmark-source")
- String getKafkaSourceTopic();
+ @Default.String("nexmark-events")
+ String getKafkaEventsTopic();
Review comment:
I think we can have only one option for sink and source of events and
another option for results topic. When we run test with modes `PUBLISH_ONLY` or
`SUBSCRIBE_ONLY` we only either write or read events. So, the generic option
`kafkaTopic` should be enough. In the same time, when we run it with `COMBINED`
then we need to have one common topic for writes/reads. So, in this case it
should be enough too.
Therefore, I named events topic option as just `kafkaTopic` and results
topic option as `kafkaResultsTopic` (since it should be separate topic for
results).
Are you ok with this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 98334)
Time Spent: 1.5h (was: 1h 20m)
> Refactor COMBINE mode for reading and writing from/to Pub/Sub and Kafka in
> Nexmark
> ----------------------------------------------------------------------------------
>
> Key: BEAM-4048
> URL: https://issues.apache.org/jira/browse/BEAM-4048
> Project: Beam
> Issue Type: Improvement
> Components: examples-nexmark
> Reporter: Etienne Chauchot
> Assignee: Alexey Romanenko
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
