[
https://issues.apache.org/jira/browse/BEAM-4048?focusedWorklogId=98437&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-98437
]
ASF GitHub Bot logged work on BEAM-4048:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/May/18 15:00
Start Date: 04/May/18 15:00
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on a change in pull request
#5249: [BEAM-4048] Refactor COMBINE mode for reading/writing from/to Pub/Sub
and Kafka in Nexmark
URL: https://github.com/apache/beam/pull/5249#discussion_r186110404
##########
File path:
sdks/java/nexmark/src/main/java/org/apache/beam/sdk/nexmark/NexmarkLauncher.java
##########
@@ -860,14 +866,14 @@ private void sinkEventsToPubsub(PCollection<Event>
events, long now) {
* Send {@code formattedResults} to Kafka.
*/
private void sinkResultsToKafka(PCollection<String> formattedResults) {
- checkArgument(!Strings.isNullOrEmpty(options.getBootstrapServers()),
- "Missing --bootstrapServers");
+ NexmarkUtils.console("Writing results to Kafka Topic %s",
options.getKafkaResultsTopic());
Review comment:
Done in all places.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 98437)
Time Spent: 1h 50m (was: 1h 40m)
> Refactor COMBINE mode for reading and writing from/to Pub/Sub and Kafka in
> Nexmark
> ----------------------------------------------------------------------------------
>
> Key: BEAM-4048
> URL: https://issues.apache.org/jira/browse/BEAM-4048
> Project: Beam
> Issue Type: Improvement
> Components: examples-nexmark
> Reporter: Etienne Chauchot
> Assignee: Alexey Romanenko
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
