[
https://issues.apache.org/jira/browse/BEAM-4048?focusedWorklogId=98133&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-98133
]
ASF GitHub Bot logged work on BEAM-4048:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/May/18 06:29
Start Date: 04/May/18 06:29
Worklog Time Spent: 10m
Work Description: rangadi commented on a change in pull request #5249:
[BEAM-4048] Refactor COMBINE mode for reading/writing from/to Pub/Sub and Kafka
in Nexmark
URL: https://github.com/apache/beam/pull/5249#discussion_r185995871
##########
File path:
sdks/java/nexmark/src/main/java/org/apache/beam/sdk/nexmark/NexmarkOptions.java
##########
@@ -407,19 +407,19 @@
void setQueryLanguage(String value);
- @Description("Base name of Kafka source topic in streaming mode.")
+ @Description("Base name of Kafka events topic in streaming mode.")
@Nullable
- @Default.String("nexmark-source")
- String getKafkaSourceTopic();
+ @Default.String("nexmark-events")
+ String getKafkaEventsTopic();
Review comment:
Not sure if the new name sounds better. Normally just `kafkaTopic` is fine.
Since there are are both sink and source topics, explicit source and sink
sounds good. I would go with consistency between pubsub and Kafka topic option
here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 98133)
Time Spent: 1h (was: 50m)
> Refactor COMBINE mode for reading and writing from/to Pub/Sub and Kafka in
> Nexmark
> ----------------------------------------------------------------------------------
>
> Key: BEAM-4048
> URL: https://issues.apache.org/jira/browse/BEAM-4048
> Project: Beam
> Issue Type: Improvement
> Components: examples-nexmark
> Reporter: Etienne Chauchot
> Assignee: Alexey Romanenko
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
