[
https://issues.apache.org/jira/browse/BEAM-4077?focusedWorklogId=105982&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105982
]
ASF GitHub Bot logged work on BEAM-4077:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/May/18 18:55
Start Date: 25/May/18 18:55
Worklog Time Spent: 10m
Work Description: kennknowles opened a new pull request #5488:
[BEAM-4077] Schema fields are non-null by default
URL: https://github.com/apache/beam/pull/5488
Before this change, every field was explicitly called out as nullable or
not. It was inconvenient. This makes them non-null by default.
------------------------
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [x] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone
(e.g. `@username`) to look at it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 105982)
Time Spent: 10m
Remaining Estimate: 0h
> Refactor builder field nullability
> ----------------------------------
>
> Key: BEAM-4077
> URL: https://issues.apache.org/jira/browse/BEAM-4077
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently the Schema builder methods take a boolean for nullability. It would
> be more standard to have separate builder methods. At this point the builder
> might as well just take the Field spec since it does not add concision.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
