[
https://issues.apache.org/jira/browse/BEAM-4077?focusedWorklogId=106013&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-106013
]
ASF GitHub Bot logged work on BEAM-4077:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/May/18 21:05
Start Date: 25/May/18 21:05
Worklog Time Spent: 10m
Work Description: kennknowles opened a new pull request #5490:
[BEAM-4077] Refactor schemas and fields for simplicity and clarity
URL: https://github.com/apache/beam/pull/5490
This refactor makes the difference between TypeName (which is not a type)
and FieldType (which is a type) more explicit and makes it easier and quicker
to construct types. It also makes the 95% case of non-null types a bit pithier.
------------------------
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [x] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone
(e.g. `@username`) to look at it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 106013)
Time Spent: 40m (was: 0.5h)
> Refactor builder field nullability
> ----------------------------------
>
> Key: BEAM-4077
> URL: https://issues.apache.org/jira/browse/BEAM-4077
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently the Schema builder methods take a boolean for nullability. It would
> be more standard to have separate builder methods. At this point the builder
> might as well just take the Field spec since it does not add concision.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
