[
https://issues.apache.org/jira/browse/BEAM-4077?focusedWorklogId=106116&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-106116
]
ASF GitHub Bot logged work on BEAM-4077:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/May/18 03:52
Start Date: 26/May/18 03:52
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #5490: [BEAM-4077]
Refactor schemas and fields for simplicity and clarity
URL: https://github.com/apache/beam/pull/5490#issuecomment-392234002
OK, I rebuilt the commit history and removed RowSqlTypes. I kept some of it
in CalciteUtils. I think we need to have SQL types independent of Beam types
unless Beam adopts the standard types. But I think that doesn't fit perfectly -
SQL has many types that are like compound types in Beam.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 106116)
Time Spent: 1h 10m (was: 1h)
> Refactor builder field nullability
> ----------------------------------
>
> Key: BEAM-4077
> URL: https://issues.apache.org/jira/browse/BEAM-4077
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Currently the Schema builder methods take a boolean for nullability. It would
> be more standard to have separate builder methods. At this point the builder
> might as well just take the Field spec since it does not add concision.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
