[
https://issues.apache.org/jira/browse/BEAM-4077?focusedWorklogId=106219&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-106219
]
ASF GitHub Bot logged work on BEAM-4077:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/May/18 20:52
Start Date: 27/May/18 20:52
Worklog Time Spent: 10m
Work Description: apilloud commented on a change in pull request #5490:
[BEAM-4077] Refactor schemas and fields, simplify a bit
URL: https://github.com/apache/beam/pull/5490#discussion_r191087804
##########
File path:
sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/JdbcDriverTest.java
##########
@@ -32,11 +32,17 @@
import org.apache.beam.sdk.extensions.sql.mock.MockedBoundedTable;
import org.apache.beam.sdk.schemas.Schema.TypeName;
import org.apache.calcite.jdbc.CalciteConnection;
+import org.junit.Before;
import org.junit.Test;
/** Test for {@link JdbcDriver}. */
public class JdbcDriverTest {
+ @Before
+ public void before() throws Exception {
+ Class.forName("org.apache.beam.sdk.extensions.sql.impl.JdbcDriver");
Review comment:
I'd like to understand the environments that require this. What runtime do
they have? This should be handled by the service file for java.sql.Driver in
Java 7+. How do we test that path?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 106219)
Time Spent: 2h (was: 1h 50m)
> Refactor builder field nullability
> ----------------------------------
>
> Key: BEAM-4077
> URL: https://issues.apache.org/jira/browse/BEAM-4077
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Currently the Schema builder methods take a boolean for nullability. It would
> be more standard to have separate builder methods. At this point the builder
> might as well just take the Field spec since it does not add concision.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
