[
https://issues.apache.org/jira/browse/BEAM-3773?focusedWorklogId=110855&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-110855
]
ASF GitHub Bot logged work on BEAM-3773:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jun/18 21:34
Start Date: 11/Jun/18 21:34
Worklog Time Spent: 10m
Work Description: apilloud commented on a change in pull request #5592:
[BEAM-3773] [SQL] Add support for setting PipelineOptions
URL: https://github.com/apache/beam/pull/5592#discussion_r194555475
##########
File path: sdks/java/extensions/sql/src/main/codegen/includes/parserImpls.ftl
##########
@@ -280,4 +285,48 @@ Schema.FieldType SimpleType() :
}
}
+SqlSetOptionBeam SqlSetOptionBeam(Span s, String scope) :
+{
+ SqlIdentifier name;
+ final SqlNode val;
+}
+{
+ (
+ <SET> {
Review comment:
The JDBC path gives us no way to extend execute. When accessing Beam SQL
through that path all outputs from the parser must be self executing, which
`SqlSetOptionBeam` is. Are you already using `SET/RESET` for something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 110855)
Time Spent: 16h (was: 15h 50m)
> [SQL] Investigate JDBC interface for Beam SQL
> ---------------------------------------------
>
> Key: BEAM-3773
> URL: https://issues.apache.org/jira/browse/BEAM-3773
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Anton Kedin
> Assignee: Andrew Pilloud
> Priority: Major
> Time Spent: 16h
> Remaining Estimate: 0h
>
> JDBC allows integration with a lot of third-party tools, e.g
> [Zeppelin|https://zeppelin.apache.org/docs/0.7.0/manual/interpreters.html],
> [sqlline|https://github.com/julianhyde/sqlline]. We should look into how
> feasible it is to implement a JDBC interface for Beam SQL
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
