[
https://issues.apache.org/jira/browse/BEAM-4000?focusedWorklogId=118498&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-118498
]
ASF GitHub Bot logged work on BEAM-4000:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jul/18 00:05
Start Date: 03/Jul/18 00:05
Worklog Time Spent: 10m
Work Description: charlesccychen commented on a change in pull request
#5715: [BEAM-4000] Futurize io subpackage
URL: https://github.com/apache/beam/pull/5715#discussion_r198317709
##########
File path: sdks/python/apache_beam/io/gcp/gcsio.py
##########
@@ -483,6 +489,7 @@ def size(self):
return self._size
def get_range(self, start, end):
+ self._download_stream.seek(0)
Review comment:
This is fine, but I'm curious why you had to make this change--did you
encounter an error before this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 118498)
> Futurize and fix python 2 compatibility for io subpackage
> ---------------------------------------------------------
>
> Key: BEAM-4000
> URL: https://issues.apache.org/jira/browse/BEAM-4000
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Matthias Feys
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
