[
https://issues.apache.org/jira/browse/BEAM-4006?focusedWorklogId=120213&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-120213
]
ASF GitHub Bot logged work on BEAM-4006:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jul/18 10:35
Start Date: 07/Jul/18 10:35
Worklog Time Spent: 10m
Work Description: Fematich commented on a change in pull request #5729:
[BEAM-4006] Futurize transforms subpackage
URL: https://github.com/apache/beam/pull/5729#discussion_r200808916
##########
File path: sdks/python/apache_beam/transforms/window.py
##########
@@ -245,10 +274,17 @@ def __init__(self, value, timestamp):
self.value = value
self.timestamp = Timestamp.of(timestamp)
- def __cmp__(self, other):
+ def __eq__(self, other):
+ return (type(self) == type(other)) and (self.value == other.value) and \
+ (self.timestamp == other.timestamp)
+
+ def __hash__(self):
+ return hash((type(self), self.value, self.timestamp))
+
+ def __lt__(self, other):
if type(self) is not type(other):
- return cmp(type(self), type(other))
- return cmp((self.value, self.timestamp), (other.value, other.timestamp))
+ return type(self) < type(other)
Review comment:
Indeed! Using the hash of type should resolve this issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 120213)
Time Spent: 1h 50m (was: 1h 40m)
> Futurize and fix python 2 compatibility for transforms subpackage
> -----------------------------------------------------------------
>
> Key: BEAM-4006
> URL: https://issues.apache.org/jira/browse/BEAM-4006
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Matthias Feys
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
