[
https://issues.apache.org/jira/browse/BEAM-4006?focusedWorklogId=120530&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-120530
]
ASF GitHub Bot logged work on BEAM-4006:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jul/18 22:27
Start Date: 08/Jul/18 22:27
Worklog Time Spent: 10m
Work Description: Fematich commented on a change in pull request #5729:
[BEAM-4006] Futurize transforms subpackage
URL: https://github.com/apache/beam/pull/5729#discussion_r200856328
##########
File path: sdks/python/apache_beam/transforms/core.py
##########
@@ -1855,7 +1865,7 @@ def __init__(self, value):
value: An object of values for the PCollection
"""
super(Create, self).__init__()
- if isinstance(value, string_types):
+ if isinstance(value, (unicode, str)):
Review comment:
I have added bytes in the list!
Strings in Python2 didn't have a `__iter__()` method, the for loop
functionality was provided by the `__getitem__()` method. That's the reason I
suggested to use the `hasattr(values,'__iter__')` attribute check. However, in
Python3 `__iter__()` is available for Strings as well, so the check wouldn't
work for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 120530)
Time Spent: 3.5h (was: 3h 20m)
> Futurize and fix python 2 compatibility for transforms subpackage
> -----------------------------------------------------------------
>
> Key: BEAM-4006
> URL: https://issues.apache.org/jira/browse/BEAM-4006
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Matthias Feys
> Priority: Major
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
