[
https://issues.apache.org/jira/browse/BEAM-4006?focusedWorklogId=120228&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-120228
]
ASF GitHub Bot logged work on BEAM-4006:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jul/18 11:48
Start Date: 07/Jul/18 11:48
Worklog Time Spent: 10m
Work Description: Fematich commented on a change in pull request #5729:
[BEAM-4006] Futurize transforms subpackage
URL: https://github.com/apache/beam/pull/5729#discussion_r200810287
##########
File path: sdks/python/apache_beam/transforms/ptransform.py
##########
@@ -622,7 +626,7 @@ def __init__(self, fn, *args, **kwargs):
super(PTransformWithSideInputs, self).__init__()
if (any([isinstance(v, pvalue.PCollection) for v in args]) or
- any([isinstance(v, pvalue.PCollection) for v in kwargs.itervalues()])):
+ any([isinstance(v, pvalue.PCollection) for v in itervalues(kwargs)])):
Review comment:
This is a bit less optimal in Python2, but since it's only in the __init__,
I'll change it to `.values()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 120228)
Time Spent: 2h 50m (was: 2h 40m)
> Futurize and fix python 2 compatibility for transforms subpackage
> -----------------------------------------------------------------
>
> Key: BEAM-4006
> URL: https://issues.apache.org/jira/browse/BEAM-4006
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Matthias Feys
> Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
