[
https://issues.apache.org/jira/browse/BEAM-4006?focusedWorklogId=120514&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-120514
]
ASF GitHub Bot logged work on BEAM-4006:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jul/18 21:28
Start Date: 08/Jul/18 21:28
Worklog Time Spent: 10m
Work Description: charlesccychen commented on a change in pull request
#5729: [BEAM-4006] Futurize transforms subpackage
URL: https://github.com/apache/beam/pull/5729#discussion_r200854567
##########
File path: sdks/python/apache_beam/transforms/core.py
##########
@@ -1855,7 +1865,7 @@ def __init__(self, value):
value: An object of values for the PCollection
"""
super(Create, self).__init__()
- if isinstance(value, string_types):
+ if isinstance(value, (unicode, str)):
Review comment:
The intention of this line is to prohibit string types from being returned
where we expect an iterable of items. Strings technically are iterable (and
return individual characters), so we want to prevent them from being returned
accidentally (e.g., a user may intend to return a single string, but we don't
want to interpret it as its individual characters). In both Python 2 and
Python 3, string types are iterable, so I think we should add `bytes` to this
list of "blacklisted" return types.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 120514)
Time Spent: 3h 10m (was: 3h)
> Futurize and fix python 2 compatibility for transforms subpackage
> -----------------------------------------------------------------
>
> Key: BEAM-4006
> URL: https://issues.apache.org/jira/browse/BEAM-4006
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Matthias Feys
> Priority: Major
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
