[
https://issues.apache.org/jira/browse/BEAM-4176?focusedWorklogId=132733&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-132733
]
ASF GitHub Bot logged work on BEAM-4176:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Aug/18 22:43
Start Date: 08/Aug/18 22:43
Worklog Time Spent: 10m
Work Description: bsidhom commented on a change in pull request #6073:
[BEAM-4176] Validate Runner Tests generalization and enable for local reference
runner
URL: https://github.com/apache/beam/pull/6073#discussion_r208758934
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -1394,5 +1420,31 @@ artifactId=${project.name}
args argsNeeded
}
}
+
+
+ /**
***********************************************************************************************/
+
+ // Method to create the PortableValidatesRunnerTask.
+ // The method takes PortableValidatesRunnerConfiguration as parameter.
+ project.ext.createPortableValidatesRunnerTask = {
+ def config = it ? it as PortableValidatesRunnerConfiguration : new
PortableValidatesRunnerConfiguration()
+ def name = config.name
+ def beamTestPipelineOptions = [
+
"--runner=org.apache.beam.runners.reference.testing.TestPortableRunner",
+ "--jobServerDriver=${config.jobServerDriver}",
+ ]
+ if(config.jobServerConfig){
+
beamTestPipelineOptions.add("--jobServerConfig=${config.jobServerConfig}")
+ }
+ project.tasks.create(name: name, type: Test) {
+ group = "Verification"
+ description = "Validates the PortableRunner with JobServer
${config.jobServerDriver}"
+ systemProperty "beamTestPipelineOptions",
JsonOutput.toJson(beamTestPipelineOptions)
+ classpath = config.testClasspathConfiguration
+ testClassesDirs =
project.files(project.project(":beam-sdks-java-core").sourceSets.test.output.classesDirs,
project.project(":beam-runners-core-java").sourceSets.test.output.classesDirs)
Review comment:
Another question about the structure here: Should we add this within
`applyJavaNature`? The `ValidatesRunner` tests only work for Java-based runners
anyway (and only the only runners that exist are written in Java).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 132733)
Time Spent: 11.5h (was: 11h 20m)
> Java: Portable batch runner passes all ValidatesRunner tests that
> non-portable runner passes
> --------------------------------------------------------------------------------------------
>
> Key: BEAM-4176
> URL: https://issues.apache.org/jira/browse/BEAM-4176
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Ben Sidhom
> Priority: Major
> Time Spent: 11.5h
> Remaining Estimate: 0h
>
> We need this as a sanity check that runner execution is correct.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
