[
https://issues.apache.org/jira/browse/BEAM-4176?focusedWorklogId=133741&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-133741
]
ASF GitHub Bot logged work on BEAM-4176:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Aug/18 18:15
Start Date: 10/Aug/18 18:15
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #6073:
[BEAM-4176] Validate Runner Tests generalization and enable for local reference
runner
URL: https://github.com/apache/beam/pull/6073#discussion_r209343372
##########
File path: runners/direct-java/build.gradle
##########
@@ -65,6 +66,7 @@ dependencies {
shadow project(path: ":beam-sdks-java-core", configuration: "shadow")
shadow library.java.joda_time
shadow library.java.slf4j_api
+ shadow library.java.slf4j_simple
Review comment:
Why do you want to add slf4j_simple here?
You typically only add SLF4J logging backends as test / application
dependencies. (e..g add it to the validatesPortableRunner configuration)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 133741)
Time Spent: 13h 10m (was: 13h)
> Java: Portable batch runner passes all ValidatesRunner tests that
> non-portable runner passes
> --------------------------------------------------------------------------------------------
>
> Key: BEAM-4176
> URL: https://issues.apache.org/jira/browse/BEAM-4176
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Ben Sidhom
> Priority: Major
> Time Spent: 13h 10m
> Remaining Estimate: 0h
>
> We need this as a sanity check that runner execution is correct.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
