[ 
https://issues.apache.org/jira/browse/BEAM-4176?focusedWorklogId=133339&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-133339
 ]

ASF GitHub Bot logged work on BEAM-4176:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Aug/18 22:18
            Start Date: 09/Aug/18 22:18
    Worklog Time Spent: 10m 
      Work Description: bsidhom commented on a change in pull request #6073: 
[BEAM-4176] Validate Runner Tests generalization and enable for local reference 
runner
URL: https://github.com/apache/beam/pull/6073#discussion_r209096201
 
 

 ##########
 File path: 
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
 ##########
 @@ -1425,6 +1425,7 @@ artifactId=${project.name}
     /** 
***********************************************************************************************/
 
     // Method to create the PortableValidatesRunnerTask.
+    // Generated task expect :beam-sdks-java-core and :beam-runners-core-java 
to be in the class path.
 
 Review comment:
   Reword this to make it clear this is a gradle evaluation dependency (rather 
than a java classpath issue).
   
   Specifically, users must make sure the following is in the consuming 
module's `build.gradle` file:
   
   ```
   evaluationDependsOn(":beam-sdks-java-core")
   evaluationDependsOn(":beam-runners-core-java")
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 133339)
    Time Spent: 12h 10m  (was: 12h)

> Java: Portable batch runner passes all ValidatesRunner tests that 
> non-portable runner passes
> --------------------------------------------------------------------------------------------
>
>                 Key: BEAM-4176
>                 URL: https://issues.apache.org/jira/browse/BEAM-4176
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-flink
>            Reporter: Ben Sidhom
>            Priority: Major
>          Time Spent: 12h 10m
>  Remaining Estimate: 0h
>
> We need this as a sanity check that runner execution is correct.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to